[Improvement] Removes ~ alias for path import #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizkenyon
approved these changes
Sep 18, 2024
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| # @shopify/shopify-app-template-remix | |||
|
|
|||
| ## Unreleased | |||
There was a problem hiding this comment.
You can have this as todays date because it will be released as soon as we merge.
There was a problem hiding this comment.
thank you, I changed to today
github-actions bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
[Improvement] Removes ~ alias for path import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
We don't use
~import anywhere in the code and don't have it configure for both JS and TS. Therefore, we don't need this alias at all.WHAT is this pull request doing?
~path aliasTest this PR
pnpm buildoryarn buildsuccessfully shows that all the imports are resolved correctly.Checklist
README.mdfile and other related documentation, if applicableCHANGELOG.md